Merged
Conversation
Add sample Go backend server so that nodejs version and dependency can be removed. Go is likely already present on build system due to other istio components usage.
lizan
approved these changes
Jan 6, 2017
qiwzhang
reviewed
Jan 6, 2017
Contributor
qiwzhang
left a comment
qiwzhang
left a comment
There was a problem hiding this comment.
Please remove node js files if we have go one.
Contributor
Author
|
2188dcf removes node.js and package.json |
chowchow316
pushed a commit
that referenced
this pull request
Jan 30, 2017
* Add golang echo backend sample Add sample Go backend server so that nodejs version and dependency can be removed. Go is likely already present on build system due to other istio components usage. * Remove nodejs echo backend
qiwzhang
added a commit
that referenced
this pull request
Feb 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sample Go backend server so that nodejs version and dependency can
be removed. Go is likely already present on build system due to other
istio components usage.